🛠️ Refactor suggestion | 🟠 Major

Add functional tests for the delete action and confirmation flow.

The current tests only verify UI rendering. Essential tests are missing for the core delete functionality, confirmation dialog interaction, and error handling.

Consider adding these test cases:

1. Confirmation dialog display test: Verify that pressing 'x' triggers the confirmation dialog
2. Successful deletion test: Verify file is deleted after confirming
3. Deletion cancellation test: Verify file is NOT deleted after canceling
4. Error handling tests: Test permission errors and file-not-found scenarios
5. Post-deletion behavior: Verify the menu closes or refreshes after deletion

Example test structure:

test('delete file shows confirmation dialog', async () => {
  await withCachedReadOnlyFixture(
    {
      'test-project': {
        'test.md': '# Test',
      },
    },
    async (fixture) => {
      const file = createFileInfo(
        fixture.path,
        'test-project/test.md',
        'project-memory',
      );
      const onClose = vi.fn();

      const { stdin, lastFrame } = render(
        <MenuActions file={file} onClose={onClose} />,
      );

      // Trigger delete action
      stdin.write('x');

      await waitFor(() => {
        const output = lastFrame();
        if (!output || !output.includes('Delete "test.md"?')) {
          throw new Error('Confirmation dialog not shown');
        }
      }, 100);

      // Verify confirmation message
      expect(lastFrame()).toContain('Delete "test.md"?');
      expect(lastFrame()).toContain('cannot be undone');
    },
  );
});

test('delete file removes file after confirmation', async () => {
  // Test actual file deletion after Y confirmation
});

test('delete file cancels when user declines', async () => {
  // Test file is NOT deleted after N/Esc
});

Would you like me to generate complete test implementations for the delete functionality?

In src/components/FileList/MenuActions.test.tsx around line 57, the tests only
assert UI rendering and lack functional coverage for the delete action and
confirmation flow; add tests that (1) press 'x' to open the confirmation dialog
and assert lastFrame() contains 'Delete "filename"?' and 'cannot be undone', (2)
simulate confirming deletion (write 'y' or Enter) and verify the file is removed
from the fixture (use withCachedReadOnlyFixture and createFileInfo) and any
expected UI/menu refresh or onClose is called, (3) simulate cancelling deletion
('n' or Escape) and assert the file still exists and menu remains/open state is
unchanged, (4) add error-handling tests by mocking the delete operation to throw
permission or not-found errors and assert appropriate error messages are shown,
and (5) assert post-deletion behavior such as the menu closing or refresh by
checking onClose was called or lastFrame() no longer shows the deleted file; for
all tests use render to obtain stdin/lastFrame, waitFor to poll UI changes, and
inspect the fixture filesystem or mocked delete calls to confirm side effects.

⚠️ Potential issue | 🔴 Critical

Critical: Menu remains open after file deletion, showing a non-existent file.

After successfully deleting a file, the menu remains open and continues to display the now-deleted file. This creates a confusing UX where users can attempt further actions on a file that no longer exists, leading to ENOENT errors.

Consider one of these solutions:

Solution 1 (recommended): Close the menu immediately after successful deletion

Modify the performDelete function to trigger menu closure:

 const performDelete = async () => {
   await fs.unlink(file.path);
+  onClose(); // Close menu immediately after deletion
   return `✅ File deleted: ${basename(file.path)}`;
 };

Solution 2: Add a callback to refresh the parent file list

If the parent component maintains a file list that should be refreshed:

 type UseMenuProps = {
   readonly file: ClaudeFileInfo;
   readonly onClose: () => void;
+  readonly onFileDeleted?: (path: string) => void;
 };

Then call it after deletion:

 const performDelete = async () => {
   await fs.unlink(file.path);
+  onFileDeleted?.(file.path);
+  onClose();
   return `✅ File deleted: ${basename(file.path)}`;
 };